[MERGE] convert locking problems in selftest at win32 into known errors
Aaron Bentley
aaron.bentley at utoronto.ca
Fri Dec 21 15:30:04 GMT 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Alexander Belchenko wrote:
> John Arbash Meinel пишет:
>> John Arbash Meinel has voted comment.
>> Status is now: Semi-approved
>> Comment:
>> Alexander, did you have a response to Robert's comments?
>
> I sent response in November 12, 2007. Do you want another response?
> Here is: I don't understand enough some tests and some code involved in tests and don't understand
> how and when lock acquired. If bzrlib could provide some logging for each lock (from which function
> it acquired) may be I can track down these problems. But for now I don't care much why it failed, if
> it not failed on linux, so I prefer mark it as XFAIL. Because having about 50 permanently failed
> tests reduce value of selftest on win32.
As I understand it, the reason your patch hasn't been approved yet is
the style issues that Robert pointed out. Since you mostly agreed with
him, I recommend submitting an updated patch that fixes them.
While it would be nice to fix the bugs instead, we don't always have
that luxury.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHa9v80F+nu1YWqI0RAgyiAJsHDPPCeBEZP4d38LkjXdro/5AEugCfWzAy
ZMQ2k54Bsi1z1kMWtLmfqmE=
=r/x+
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list