[MERGE] convert locking problems in selftest at win32 into known errors
Alexander Belchenko
bialix at ukr.net
Fri Dec 21 15:56:46 GMT 2007
Aaron Bentley пишет:
> Alexander Belchenko wrote:
>> John Arbash Meinel пишет:
>>> John Arbash Meinel has voted comment.
>>> Status is now: Semi-approved
>>> Comment:
>>> Alexander, did you have a response to Robert's comments?
>> I sent response in November 12, 2007. Do you want another response?
>> Here is: I don't understand enough some tests and some code involved in tests and don't understand
>> how and when lock acquired. If bzrlib could provide some logging for each lock (from which function
>> it acquired) may be I can track down these problems. But for now I don't care much why it failed, if
>> it not failed on linux, so I prefer mark it as XFAIL. Because having about 50 permanently failed
>> tests reduce value of selftest on win32.
>
> As I understand it, the reason your patch hasn't been approved yet is
> the style issues that Robert pointed out. Since you mostly agreed with
> him, I recommend submitting an updated patch that fixes them.
>
> While it would be nice to fix the bugs instead, we don't always have
> that luxury.
okay.
More information about the bazaar
mailing list