bzr log http+urllib does not work, http+pycurl is too slow

John Arbash Meinel john at arbash-meinel.com
Wed Dec 12 17:28:49 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
>>>>>> "bialix" == Alexander Belchenko <bialix at ukr.net> writes:
> 
>     bialix> Aaron Bentley пишет:
>     >> Vincent Ladeuil wrote:
>     >>> Hey ! List ! What do *you* think ?
>     >> 
>     >> I think that if we're trying to use packs and the http server doesn't
>     >> support ranges, it might be nice to warn the user.  That way, people
>     >> won't just blame it on Bazaar.
> 
>     bialix> Completely agree here.
> 
> 
> Something like:
> 
> if pending > 1024 * 1024:
>    # Warn only above a threshold
>    trace.warning("Your http server can't handle ranges,"
>                  " bzr will be slower (%s useless bytes not requested)",
>                  pending)
> 
> ?
> 
> Note that message may be slightly wrong since I have no easy way
> to check the useless bytes at the beginning of the file.
> 
>         Vincent
> 
> 

Can't you just see that you got a 200 response back for a range request, rather
than a 206?

Also, I would recommend including at least the http://host portion of the URL,
and only issuing 1 warning per server. (Rather than possibly on every request.)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHYBpQJdeBCYSNAAMRAn6cAJwOhmDVqZRIDOnHqssFx0zHY7Un8wCdGqHC
Efph86hWUMWY5Blao72499o=
=kxbU
-----END PGP SIGNATURE-----



More information about the bazaar mailing list