[MERGE] Catch redirects when making directory for a new branch.

Jonathan Lange jml at mumak.net
Wed Dec 5 03:05:27 GMT 2007


On Dec 5, 2007 12:54 PM, Ian Clatworthy <ian.clatworthy at internode.on.net> wrote:
>
> Jonathan Lange wrote:
> > Hello all,
> >
> > This is the last of the patches that I would like to land for lp:///
> > support for the time being.
> >
> > This patch wraps the call of to_transport.mkdir() in cmd_push in a
> > redirect handler. The tests are both blackbox. The motivation is that
> > it would be nice for users to push to branches on Launchpad that don't
> > exist yet using the lp:/// notation. Currently, the lp:/// transport
> > raises a redirect error on mkdir(). As far as I'm aware, no other
> > transports do this, so there shouldn't be too much risk associated
> > with this change.
>
> bb:approve
>
> Looks ok to me. It might need tweaking though as it seems to have broken
> the test suite. I get 4 failures like this:
>

I've fixed the test failures. Turns out I wasn't unregistered my test transport.

jml
-------------- next part --------------
A non-text attachment was scrubbed...
Name: catch-redirect-on-mkdir-in-push-2.diff
Type: text/x-diff
Size: 10441 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071205/4ba23ea4/attachment-0001.bin 


More information about the bazaar mailing list