[MERGE] windows standalone installer creates and uses "plugins" directory for system-wide plugins (#129298)

John Arbash Meinel john at arbash-meinel.com
Sat Dec 1 14:53:52 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Alexander Belchenko ?8H5B:
>> Robert Collins ?8H5B:
>>> Robert Collins has voted approve.
>>> Status is now: Approved
>>> Comment:
>>> I think this is ok, however it's a bit strange that setting the plugin
>>> path by hand will remove the system wide plugins directory; thats not
>>> how it works on linux. If you have time I'd rather see you always append
>>> the system wide location (which is bzrlib's own plugins dir on linux)
>>> rather than only apply if if the user hasn't supplied their own path.
>>> I suggest this so that bzr will behave the same on windows and linux
>>> when a user does BZR_PLUGIN_PATH=XXX
>> Hmm. Interesting.
>> I'm thinking about BZR_PLUGIN_PATH and its masking effect, but...
> 
>> May I go a bit further and ask provoking question?
> 
> Actually in my testing loading plugins from zip is at least 2 times slower
> than from filesystem.
> 
>> May be we should move standard built-in plugins (err, very funny pun indeed)
>> [I mean launchpad and multiparent] into this system-wide directory as well
>> and simply disable our load-plugins-from-zip support?
> 
> IMO it make sense in term of speed-up (not very big actually 30ms vs 70ms on NTFS,
> or vs 90ms on FAT32). I'll do it in next patch.

Interesting. Especially considering the setuptools (easy_install) stuff claims
that scanning through zip files is faster than scanning through the filesystem.
(Which is why they prefer to use eggs extensively.)

I could see that if python has cached the zip header in memory, it doesn't have
to stat the filesystem, and can just probe the in-memory index.

However, what I remember from eggs is that they add another record to the
search path, which means 1-more place that gets probed for every egg you have.
(And probing 200 eggs doesn't seem like it could be faster than probing 1
filesystem.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHUXWAJdeBCYSNAAMRAv/9AKCbcJLlLsbJi+pk6hirXJrTKxLXaQCghHc9
PN7nPPHlt8C0G3pjNyuS2mA=
=oTlC
-----END PGP SIGNATURE-----



More information about the bazaar mailing list