[MERGE] windows standalone installer creates and uses "plugins" directory for system-wide plugins (#129298)

Alexander Belchenko bialix at ukr.net
Thu Nov 29 18:10:17 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko пишет:
> Robert Collins ?8H5B:
>> Robert Collins has voted approve.
>> Status is now: Approved
>> Comment:
>> I think this is ok, however it's a bit strange that setting the plugin
>> path by hand will remove the system wide plugins directory; thats not
>> how it works on linux. If you have time I'd rather see you always append
>> the system wide location (which is bzrlib's own plugins dir on linux)
>> rather than only apply if if the user hasn't supplied their own path.
> 
>> I suggest this so that bzr will behave the same on windows and linux
>> when a user does BZR_PLUGIN_PATH=XXX
> 
> Hmm. Interesting.
> I'm thinking about BZR_PLUGIN_PATH and its masking effect, but...
> 
> May I go a bit further and ask provoking question?

Actually in my testing loading plugins from zip is at least 2 times slower
than from filesystem.

> May be we should move standard built-in plugins (err, very funny pun indeed)
> [I mean launchpad and multiparent] into this system-wide directory as well
> and simply disable our load-plugins-from-zip support?

IMO it make sense in term of speed-up (not very big actually 30ms vs 70ms on NTFS,
or vs 90ms on FAT32). I'll do it in next patch.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHTwCJzYr338mxwCURAgCOAJ4k9KtKhWYPmC94iM66lBhtS2zawQCglMZ9
eRd2ytrx0kqIAd8HAf7GkFQ=
=36wc
-----END PGP SIGNATURE-----



More information about the bazaar mailing list