[MERGE][#172612] bzr commit: don't print the revision number twice

John Arbash Meinel john at arbash-meinel.com
Fri Nov 30 03:54:54 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Matt Nordhoff wrote:
> <https://bugs.launchpad.net/bzr/+bug/172612> was bothered by how much
> more verbose "bzr commit" has gotten.
> 
> This patch follows Lukáš Lalinský's suggestion in that bug:
> 
>> I'd personally prefer (a) with a small modification:
>>
>> Committing to: /etc/
>> modified postgresql/8.2/main/pg_hba.conf
>> modified postgresql/8.2/main/pg_ident.conf
>> Committed revision 37.
>>
>> to make is more consistant with other commands, e.g. pull:
>>
>> Using saved location: /etc/
>>  M postgresql/8.2/main/pg_hba.conf
>>  M postgresql/8.2/main/pg_ident.conf
>> All changes applied successfully.
>> Now on revision 37.
> 
> This also deprecates not passing the location argument to
> NullCommitReporter/ReportCommitToLog.started. Daniel Watkins added the
> method, and when I asked in IRC, he said:

BB:approve

If you want to test it the "right" way. You should have a test which calls
NullCommitReporter and ReportCommitToLog and doesn't pass location.

This should be wrapped in a self.callDeprecated(reporter.started, foo, bar,
location=None)

That way we can assert that it is indeed deprecated, but that the output is
still handled even if you don't supply it.

(deprecated means we don't want you to use it, but we still support it, so it
should be tested until we remove it entirely.)

For this code, I'm not going to be picky about it (nobody was using it without
location anyway). But if you wanted to get the feel for how you deprecate
something, you're welcome to do so.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHT4mNJdeBCYSNAAMRAj7/AJ9ofdn7Tqd3im1M00Y6hfQeEwddGwCeKnF1
nLJBt0TWu2EM1ZUdy/DVB00=
=KCxa
-----END PGP SIGNATURE-----



More information about the bazaar mailing list