[MERGE][#172612] bzr commit: don't print the revision number twice

Matt Nordhoff mnordhoff at mattnordhoff.com
Fri Nov 30 04:11:57 GMT 2007


(Ack. I accidentally hit "Reply" instead of "Reply All" and just sent
this to jam.)

John Arbash Meinel wrote:
> BB:approve
> 
> If you want to test it the "right" way. You should have a test which calls
> NullCommitReporter and ReportCommitToLog and doesn't pass location.
> 
> This should be wrapped in a self.callDeprecated(reporter.started, foo, bar,
> location=None)
> 
> That way we can assert that it is indeed deprecated, but that the output is
> still handled even if you don't supply it.
> 
> (deprecated means we don't want you to use it, but we still support it, so it
> should be tested until we remove it entirely.)
> 
> For this code, I'm not going to be picky about it (nobody was using it without
> location anyway). But if you wanted to get the feel for how you deprecate
> something, you're welcome to do so.

I don't think there are any tests for NullCommitReporter or
ReportCommitToLog anyway.
-- 



More information about the bazaar mailing list