[MERGE] Fix case-sensitivity detection

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


Alexander Belchenko wrote:
> Aaron Bentley пишет:
> +    def test_apply_case_conflict(self):
> +        tree = self.make_branch_and_tree('tree')
> +        # Don't try this at home, kids!
> +        # Force the tree to report that it is case insensitive, for
> conflict
> +        # resolution tests
> 
> <-- it seems you forget to force insensitiveness here, as comment claims
> I.e. the line is missed:

Here's an updated patch.

I've removed the incorrect comments for test_apply_case_conflicts, and
also added an additional pair of files ('dir/dirfile' and
'dir/dirFiLe'), to ensure that when files are created inside their
containing directory, creating files with duplicate names doesn't cause
conflicts.

> Also when you're comment on my previous attempt to introduce case
> sensitiveness detection you said test for _detect_case_handling()
> should be in workingtree_implementation group. But you're not
> provide any test for it. Is it intended or you just forget about it?

I've now provided tests for WorkingTree.case_sensitive, which is the
public API.  (presumably a tree could use some mechanism other than
_detect_case_handling() to set it.)

I'm pretty confident these updated tests will pass on win32, but I don't
have a machine handy to test with.  Could you please run them, Alexander?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHTXtc0F+nu1YWqI0RAmDIAJ0Vw89xt4ziAeKiZwAVrrz+2P5sRgCffTmw
XaY9Jx9V28i7R7oovcJeh+s=
=t0ac
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: case-sensitive-2.patch
Type: text/x-patch
Size: 15987 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071128/83115eee/attachment-0001.bin