[MERGE] Fix case-sensitivity detection

Aaron Bentley aaron.bentley at utoronto.ca
Wed Nov 28 13:54:29 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Aaron Bentley пишет:
> +    def test_apply_case_conflict(self):
> +        tree = self.make_branch_and_tree('tree')
> +        # Don't try this at home, kids!
> +        # Force the tree to report that it is case insensitive, for
> conflict
> +        # resolution tests
> 
> <-- it seems you forget to force insensitiveness here, as comment claims
> I.e. the line is missed:
>     +        tree.case_sensitive = False

Actually, it's the comment that's wrong; this is meant to test that
applying always works on every platform.

That's why I allow 'tree/FiLe.moved' or 'tree/FiLe'.

> +        self.failUnlessExists('tree/file')
> +        if not os.path.exists('tree/FiLe.moved'):
> +            self.failUnlessExists('tree/FiLe')
> 
> Also when you're comment on my previous attempt to introduce case
> sensitiveness detection you said test for _detect_case_handling()
> should be in workingtree_implementation group. But you're not
> provide any test for it. Is it intended or you just forget about it?

I guess I should be doing that.  I'm not sure it's the right way to
handle case issues in the long term, but for now, if it's public, it
should be tested.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHTXMV0F+nu1YWqI0RAkKlAJwIB2UkBZISBvFpEtqWfSaL+E/migCeKf1F
il026oBxACAS54+uXswtRe4=
=Qm+S
-----END PGP SIGNATURE-----



More information about the bazaar mailing list