[MERGE] Refactor diffing

Aaron Bentley aaron.bentley at utoronto.ca
Mon Nov 26 12:50:07 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
>> I've added a from_diff_tree factory to each Diff class.  But as you can
>> see, it doesn't simplify things too much.
> 
> I was actually thinking that __init__ would be changed rather than a
> separate method :). Still, this promotes looser coupling I guess.

Yes, I thought you meant that, but you did say "factory", and I wanted
to keep the constructors as-is, because that made it more testable and
more flexible.

Martin, do you want this in 1.0?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHSsD+0F+nu1YWqI0RArApAJ9/XrHTMG7uWwAKsoOOeZFJu8cHpwCfa4HC
A5efsAYvZ/FxjWJp4bhxa10=
=Kcrc
-----END PGP SIGNATURE-----



More information about the bazaar mailing list