[MERGE] Faster code for pushing from packs back into knits

Aaron Bentley aaron.bentley at utoronto.ca
Thu Nov 22 19:10:17 GMT 2007


Aaron Bentley has voted tweak.
Status is now: Conditionally approved
Comment:
Since you say this isn't a performance problem, I'm okay with it as is.
We can certainly look at other implementations in the future.

So the remaining issues are:
- naming of _text_by_text_join

 > +        # TODO: jam 20071116 It would be nice to have a streaming 
interface to
 > +        #       get multiple texts from a source. The source could be 
smarter
> +        #       about how it handled intermediate stages.
 > +        # TODO: jam 20071116 Consider using 'get_line_list' instead 
of lots of
> +        #       calls to get_lines()

These TODO lines look contradictory at first.  Could they maybe be 
unified?

Aaron

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C20071117002751.7F88555FBE%40juju.arbash-meinel.com%3E



More information about the bazaar mailing list