[MERGE] Faster code for pushing from packs back into knits

John Arbash Meinel john at arbash-meinel.com
Tue Nov 20 22:08:46 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> John Arbash Meinel wrote:
> 
>> +        # TODO: jam 20071116 It would be nice to have a streaming interface to
>> +        #       get multiple texts from a source. The source could be smarter
>> +        #       about how it handled intermediate stages.
> 
> Actually, we have that: Repository.iter_files_bytes.  It'll iterate
> through all versions of all files you ask about.  The knit version just
> uses versionedfile.get_line_lists(), but packs should be able to satisfy
> this more intelligently.
> 
> Aaron

Thanks for the pointer. I still want to avoid anything which ends up extracting
and holding 100 copies of a file in memory before putting it into the target.
But I'm happy to update the "TODO" to point at iter_files_bytes instead.

Then again, if we go the mpdiff route, it may be moot.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHQ1ruJdeBCYSNAAMRAi8tAJsHmsE4j+Tt2caUSK2F1QVi1pbJZgCfSHn8
199mryzV9MaMdI/A2ZerRM4=
=JDXt
-----END PGP SIGNATURE-----



More information about the bazaar mailing list