[MERGE] Rename on Windows is able to change filename case. (#77740)

Aaron Bentley aaron.bentley at utoronto.ca
Mon Nov 12 15:56:25 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Aaron Bentley ?8H5B:
>> Alexander Belchenko wrote:
>>> Windows used case insensitive filesystem therefore rename (bzr mv) should care about special case
>>> when only case is changed.
>> bb:comment
> 
>> Could you please explain why we should avoid using fancy_rename in that
>> special case.?
> 
> Because it simply did not work for this special case, but os.rename works just like a charm.

bb:approve

Well, this change is certainly better than what we have.  But it's not a
complete fix:

1. Windows may encounter case-sensitive filesystems over SMB or NFS.
2. Unix may encounter case-(insensitive + preserving) filesystems over
SMB or NFS.
3. Unix and Windows may both encounter case-insensitive filesystems over
ftp, sftp or bzr+ssh.

So while I'm willing to approve this because it likely fixes 95% of the
cases, I'd rather see a fix to fancy_rename, because it would also fix
ftp and sftp.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOHep0F+nu1YWqI0RAuJQAJ9Yg8m27MAyD6e9fLenUZ1qp8MzaQCfX81c
e9D4C8gILO1rBBbJd9RQ8xQ=
=MPi5
-----END PGP SIGNATURE-----



More information about the bazaar mailing list