[MERGE] Rename on Windows is able to change filename case. (#77740)

Alexander Belchenko bialix at ukr.net
Mon Nov 12 16:42:21 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley пишет:
> Alexander Belchenko wrote:
>> Aaron Bentley ?8H5B:
>>> Alexander Belchenko wrote:
>>>> Windows used case insensitive filesystem therefore rename (bzr mv) should care about special case
>>>> when only case is changed.
>>> bb:comment
>>> Could you please explain why we should avoid using fancy_rename in that
>>> special case.?
>> Because it simply did not work for this special case, but os.rename works just like a charm.
> 
> bb:approve
> 
> Well, this change is certainly better than what we have.  But it's not a
> complete fix:
> 
> 1. Windows may encounter case-sensitive filesystems over SMB or NFS.
> 2. Unix may encounter case-(insensitive + preserving) filesystems over
> SMB or NFS.
> 3. Unix and Windows may both encounter case-insensitive filesystems over
> ftp, sftp or bzr+ssh.
> 
> So while I'm willing to approve this because it likely fixes 95% of the
> cases, I'd rather see a fix to fancy_rename, because it would also fix
> ftp and sftp.

I'm also like to see the complete fix, but we need some way
to detect case-insensitivity first. In my spec:
http://bazaar-vcs.org/CaseInsensitiveWorkingTreeSupport
I assume that we can fast detect case sensitiveness at the moment when we open working tree.
Unfortunately osutils is abstract layer, and checking case sensitiveness in each call of
fancy_rename is overkill. Do you have better ideas?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHOIJtzYr338mxwCURAlI+AJ9EMmW7VU0g/VHKI7F5RNKFjcP7/ACghpjO
9njDZcvttvQ/jOI6dnKuVXo=
=Wek2
-----END PGP SIGNATURE-----



More information about the bazaar mailing list