[MERGE] Use a dict to access stat cache information from dirstate.

Robert Collins robertc at robertcollins.net
Wed Oct 24 10:02:30 BST 2007


On Wed, 2007-10-24 at 17:01 +1000, Ian Clatworthy wrote:

> >> For a partial commit, perhaps we should only loop over those entries
> >> instead of all of them as well?
> > 
> > Yes, this would be a good future improvement. However, its worth noting
> > that the third of my performance figures *was* a partial commit, so the
> > time to populate the cache would seem to be tiny.
> 
> I did see that. So incremental commit is now 15s while commit of 1 file
> is now 10s. I wonder how many of those 10s is spent on O(n) tasks that
> could be O(1) instead?

Well, some :). callgrind gives pretty good hints at the moment.

> That aside, really well done on these improvements. The old commit
> performance vs the new commit performance are chalk and cheese.

:)

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071024/07a3e950/attachment.pgp 


More information about the bazaar mailing list