[QBZR/RFC] Add unidiff format to diff dialog

Alexander Belchenko bialix at ukr.net
Fri Oct 19 19:30:47 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Goffredo Baroncelli пишет:
> On Thursday 18 October 2007, you (Alexander Belchenko) wrote:
>> Goffredo Baroncelli пишет:
>>> I worked a bit on my patch:
>>> - now the _() function should translate correctly
>>> - the unidiff diff should be english only (for the moment)
>>>
>>> I didn't touched the po/po.* files, because I don't know how gettext work.
>>>
>>> Please Alexander give me a feedback. 
>> IMO, we don't need special dictionary to transform english status
>> words to translated ones. Instead we need to use function i18n.N_()
>> that provide non-translated string, and use i18n._() when we need
>> translations.
> 
> In my code, some decision were done on the basis of the diff.status value. So 
> (in my mind) it was a status not a message.
> On the basis of the status value I generated a header for the file.
> 
> In my latest code I moved the header generation in the TreeDiff class. So this 
> is not necessary anymore.
> 
> The header is HTML based, and is similar to the side-by-side header. Enclosed 
> you can see a screenshot. 
> 
> The code is under working, in any case you can pull my branch at
> 
> http://goffredo-baroncelli.homelinux.net/bazaar/qbzr-repo/qbzr.ghigo
> 
> and you can browse my code at
> 
> http://cassiopea.homelinux.net/bazaar-dev/qbzr.ghigo?cmd=inventory
>  
> Please, give me your opinion.

My first question is: how it will look for renamed files?

- --
[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHGPfWzYr338mxwCURAiMuAJ4630j7UQO5RD0B+z4mlTQlnmLqDwCgkQ48
DffF1999RzTu3UaS27uLkZI=
=jlAO
-----END PGP SIGNATURE-----



More information about the bazaar mailing list