[QBZR/RFC] Add unidiff format to diff dialog
Goffredo Baroncelli
kreijack at tiscalinet.it
Thu Oct 18 18:28:25 BST 2007
On Thursday 18 October 2007, you (Alexander Belchenko) wrote:
> Goffredo Baroncelli пишет:
> > I worked a bit on my patch:
> > - now the _() function should translate correctly
> > - the unidiff diff should be english only (for the moment)
> >
> > I didn't touched the po/po.* files, because I don't know how gettext work.
> >
> > Please Alexander give me a feedback.
>
> IMO, we don't need special dictionary to transform english status
> words to translated ones. Instead we need to use function i18n.N_()
> that provide non-translated string, and use i18n._() when we need
> translations.
In my code, some decision were done on the basis of the diff.status value. So
(in my mind) it was a status not a message.
On the basis of the status value I generated a header for the file.
In my latest code I moved the header generation in the TreeDiff class. So this
is not necessary anymore.
The header is HTML based, and is similar to the side-by-side header. Enclosed
you can see a screenshot.
The code is under working, in any case you can pull my branch at
http://goffredo-baroncelli.homelinux.net/bazaar/qbzr-repo/qbzr.ghigo
and you can browse my code at
http://cassiopea.homelinux.net/bazaar-dev/qbzr.ghigo?cmd=inventory
Please, give me your opinion.
Br
Goffredo
>
> Attached the diff against your last patch and complete patch against
> Lukas' main branch.
> I'm also added blank line between files in unidiff output.
>
> Alexander
>
--
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack at inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87 87C0 BB86 505C 6B2A CFF9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/png
Size: 39615 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071018/d383d9fe/attachment-0001.png
More information about the bazaar
mailing list