Request: post-commit hook needs more info

Robert Collins robertc at robertcollins.net
Thu Oct 18 00:55:24 BST 2007


On Wed, 2007-10-17 at 17:21 -0500, John Arbash Meinel wrote:
> 
> 
> Well, a very specific use case for post-commit is to write out a
> ChangeLog. And
> without having a Tree, you don't know where to put it.

I would add a post-commit WorkingTree hook as well then.

> The branch is not a good place, since it is completely wrong for a
> lightweight
> checkout.

For outputting a ChangeLog - agreed.

> To *do* a commit you must have a Tree. 

Well, MutableTree, not WorkingTree - we commit quite happily with
MemoryTree during tests.

> So it seems reasonable that the *policy* is set by the Branch (what is
> allowed
> here), but the hooks can have access to the location where the files
> are being
> changed.

I still disagree with altering the branch hooks to have the tree object
passed in.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20071018/b6444a49/attachment.pgp 


More information about the bazaar mailing list