Request: post-commit hook needs more info

John Arbash Meinel john at arbash-meinel.com
Thu Oct 18 03:20:40 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Wed, 2007-10-17 at 17:21 -0500, John Arbash Meinel wrote:

>> To *do* a commit you must have a Tree. 
> 
> Well, MutableTree, not WorkingTree - we commit quite happily with
> MemoryTree during tests.
> 

Sure, and I have MinimalTree in cvsps. But... they are all Trees. They may not
have a basedir. But you cannot have a commit without a Tree.

>> So it seems reasonable that the *policy* is set by the Branch (what is
>> allowed
>> here), but the hooks can have access to the location where the files
>> are being
>> changed.
> 
> I still disagree with altering the branch hooks to have the tree object
> passed in.
> 
> -Rob
> 

Anything more concrete as to why?

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHFsL3JdeBCYSNAAMRAjprAJ9wDjIyzVyTY7PUdmtEYFKcjq5TrQCghYWW
QWbT2FPaL9yfqHlkoyxfnQM=
=DrOr
-----END PGP SIGNATURE-----



More information about the bazaar mailing list