[MERGE] add a command for managing the Launchpad user ID.

James Henstridge james at jamesh.id.au
Tue Oct 16 03:18:34 BST 2007


On 16/10/2007, John Arbash Meinel <john at arbash-meinel.com> wrote:
> John Arbash Meinel has voted approve.
> Status is now: Semi-approved
> Comment:
> Would it be reasonable when checking the ssh keys to check that the user
> actually has access to those keys? Right now you seem to just check that
> there does exist an ssh key for that username, but there is a bit more
> to check that the user can actually access LP correctly.
>
> One could (arguably) actually just try to connect to a known/valid
> bzr+ssh/sftp branch. Maybe just trying to connect to
> bzr+ssh://bazaar.launchpad.net/~user/+junk and seeing that you don't get
> NoSuchFile or something like that.

Well, currently the error condition for failed logins is not particularly nice:
    https://bugs.launchpad.net/bzr/+bug/82634

Maybe this would be worth adding when the network error handling in
the SmartClient code is improved.

James.



More information about the bazaar mailing list