[QBZR][MERGE] Add unidiff format to diff dialog

Alexander Belchenko bialix at ukr.net
Wed Oct 10 21:16:58 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Goffredo Baroncelli пишет:
> On Monday 08 October 2007, Lukáš Lalinský wrote:
>> On 10/8/07, Goffredo Baroncelli <kreijack at tiscalinet.it> wrote:
> [...]
>> - please use QStackedWidget instead of
>> setVisible(True)/setVisible(False) for swapping the diff views. It
>> should be a little bit faster that way, but mainly it would produce
>> less flickering.
>>
> 
> Ok, before I searched a similar widget, but I wasn't able to find it.
> Thanks for the suggestion, now the enclosed patch uses QStackedWidget.
> 
>> Lukas
>>
> BR
> Goffredo

Lukas is already merge your patch, thanks Goffredo.

IMO, it make sense to have unified diff more similar to side-by-side diff
in terms of colors: can we have for unidiff colored background
(red/green) with black text instead of red/green text on white background?
IIRC, Trac use background colors and did it very nice.

Also, it will be very nice to address bug
https://bugs.launchpad.net/qbzr/+bug/148409

Lukas, may be it worth to rename this option from --inline to --unidiff?

- --
[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHDTM6zYr338mxwCURAo8vAJ9u3Tql7C1+AKWit/thrWBL7kkf9wCgljvd
h0ZkJFU88xTFI7fWhRSqdy0=
=Lq4M
-----END PGP SIGNATURE-----



More information about the bazaar mailing list