[MERGE] bzr+https is not a supported protocol

[Martin Pool]

Martin Pool has voted tweak.
Status is now: Semi-approved
Comment:
Thanks for the patch, John.


+register_transport_proto('bzr+https://',
+#                help="Fast access using the Bazaar smart server over 
HTTPS."
+             )

Why do you have the help string commented out?


-        assert base.startswith('bzr+http://')
+        assert ( base.startswith('bzr+http://') or 
base.startswith('bzr+https://') )

I think we should just remove that assertion, though you weren't to know 
that.

I'm actually a little surprised that so little is needed to enable it; 
that's quite cool.

I would think for a test it would be enough to construct one of these 
and then check that it is capable of rpcs and that the underlying medium 
is  https.  Any comments?




For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C20070926090333.GF19688%40inodes.org%3E