[RFC] Dropping CommitBuilder supply-root compatibility thunk

Aaron Bentley aaron.bentley at utoronto.ca
Fri Sep 28 02:42:39 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Currently if a root is not supplied to commitbuilder, it is a
> deprecation warning, I'd like to make it into an error.

Makes sense to me.  I'm not sure there are *any* other clients of this
API, much less un-updated ones.

> This will allow returning inventory delta entries from
> record_entry_contents, and feed them into the
> update_to_one_parent_via_delta api I posted last night, as well as the
> commit reporter, saving duplicated diff-logic that currently exists.

I don't see why keeping it the way it is would prevent that, but it
certainly sounds like the right direction to me.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG/FwP0F+nu1YWqI0RAgdyAJ9cu5FLM0sG1bgKFisvmlm8x7zHGwCcDX6v
q7+y+1rpCAwPPseymSNtrZ0=
=xcdn
-----END PGP SIGNATURE-----



More information about the bazaar mailing list