[RFC] Dropping CommitBuilder supply-root compatibility thunk
Robert Collins
robertc at robertcollins.net
Fri Sep 28 02:54:02 BST 2007
On Thu, 2007-09-27 at 21:42 -0400, Aaron Bentley wrote:
>
> I don't see why keeping it the way it is would prevent that, but it
> certainly sounds like the right direction to me.
If the commit builder using the return value did not supply a root, a
change to the root wouldn't be returned, and would be dropped in the
update to the basis - its a corner case to be sure, and a deprecation
warning would ensue. (Alternatively the return value would have to
return an iterable of changes rather than a single change, which is less
clear IMO).
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070928/83597990/attachment.pgp
More information about the bazaar
mailing list