[MERGE] Add revert --forget-merges

Martin Pool mbp at sourcefrog.net
Wed Sep 26 00:37:42 BST 2007


On 9/26/07, Robert Collins <robertc at robertcollins.net> wrote:
> On Mon, 2007-09-24 at 15:34 +1000, Martin Pool wrote:
> > +
> > +    @staticmethod
> > +    def _revert_tree_to_revision(tree, revision, file_list,
> > no_backup):
>
> This smells strange to me. Command classes have useful attributes like
> output files that are encoded correctly etc; why should this method be a
> static method? If it deserves to be called from outside the Command
> object, surely it should not be in builtins.py at all..

It's a static method just because it does not depend on the state of
the Command object.  Maybe it should be an instance method anyhow.

-- 
Martin



More information about the bazaar mailing list