[MERGE] Add revert --forget-merges

Robert Collins robertc at robertcollins.net
Tue Sep 25 22:39:24 BST 2007


On Mon, 2007-09-24 at 15:34 +1000, Martin Pool wrote:
> +
> +    @staticmethod
> +    def _revert_tree_to_revision(tree, revision, file_list,
> no_backup):

This smells strange to me. Command classes have useful attributes like
output files that are encoded correctly etc; why should this method be a
static method? If it deserves to be called from outside the Command
object, surely it should not be in builtins.py at all..

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070926/63e5b91b/attachment.pgp 


More information about the bazaar mailing list