RFC: make Repository.add_inventory not autolock

[Robert Collins]

On Fri, 2007-09-21 at 13:49 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Martin Pool wrote:
> > On 9/13/07, Robert Collins <robertc at robertcollins.net> wrote:
> >> Repository.add_inventory currently has a an autolocking decorator. As
> >> this api is only useful in:
> >>  - tests that want crafted commits
> >>  - commit (which is in a large lock scope anyway)
> >>  - push/pull (ditto)
> >>  - bundle insertion (ditto)
> >>
> >> The autolocking decorator seems unneeded therefore.
> > 
> > OK.
> > 
> 
> It seems reasonable, but do you actually save much? It seems like we
> should only call "add_inventory" 1 time per commit.

Thats true; but its still wasted effort; we have no use case to be
calling add  inventory outside of commit/reconcile/fetch/tests.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070922/779bf149/attachment.pgp