RFC: make Repository.add_inventory not autolock

John Arbash Meinel john at arbash-meinel.com
Fri Sep 21 19:49:38 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On 9/13/07, Robert Collins <robertc at robertcollins.net> wrote:
>> Repository.add_inventory currently has a an autolocking decorator. As
>> this api is only useful in:
>>  - tests that want crafted commits
>>  - commit (which is in a large lock scope anyway)
>>  - push/pull (ditto)
>>  - bundle insertion (ditto)
>>
>> The autolocking decorator seems unneeded therefore.
> 
> OK.
> 

It seems reasonable, but do you actually save much? It seems like we
should only call "add_inventory" 1 time per commit.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG9BJCJdeBCYSNAAMRAmSfAKC5vFU4uP8g9UoJrpTJIBrMyynsdQCdFa/8
WCsp/+ahVPAg7bAxOa5OUGs=
=c2uM
-----END PGP SIGNATURE-----



More information about the bazaar mailing list