RFC: remove safe_revision_id ?
John Arbash Meinel
john at arbash-meinel.com
Fri Sep 21 18:45:57 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Martin Pool wrote:
> On 9/10/07, Robert Collins <robertc at robertcollins.net> wrote:
>> We've now had safe_revision_id for a couple of releases and are not
>> seeing deprecation warnings...
>> while its not huge, it is an overhead - are we in a position to remove
>> it for e.g. 0.92
> Removing it is ok with me. I think John added it, so it might be
> worth just checking with him whether he thinks it's now safe to
We *might* want to have it on a few functions that we consider very
public, and very likely to get it wrong. But in general, calling code
should be considered safe, and it does add a measurable overhead.
You'll always want to remove 'safe_file_id'.
(Note: I would probably just remove the locations that call it, not the
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar