[MERGE] 40% faster partial commits

Alexander Belchenko bialix at ukr.net
Thu Sep 20 11:01:00 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins пишет:
> On Thu, 2007-09-20 at 10:29 +0300, Alexander Belchenko wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Robert Collins пишет:
>>> This makes partial commits walk much less data, with approximately 40%
>>> increase in speed.
>>>
>>> The basic approach is to use the iter_entries_by_dir specific_file_ids
>>> parameter, after tweaking it to optionally match the behaviour wanted by
>>> commit.
>> bb:comment
>>
>> Partial commit has serious bug: https://bugs.launchpad.net/bugs/140419
>> Does your patch handle this case?
> 
> I'm aware of the bug; I don't know. I'm currently on an optimisation
> pass for incremental commit, this patch basically makes the real speed
> hogs more visible for me.
> 
> I suggest that the test case for that bug be added as XFAIL, then we can
> see if we fix it more easily.

I just sent patch with XFAIL test, and now I run this test with your patch.
And it seems, that your patch fix this bug as well. If my testing is correct
I think you need resubmit your patch, with corresponding test, and mention
bugfix in NEWS.

[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG8kTczYr338mxwCURAn25AJ9mE5hz4lJ5Uo3v75lvzHrudyHHagCgkhbc
nJwZLXI2lHBxAu3eM7+RtcU=
=DyIq
-----END PGP SIGNATURE-----



More information about the bazaar mailing list