[MERGE] Change CommitBuilder factory delegation to allow simple declaration.

[Robert Collins]

On Fri, 2007-09-14 at 16:46 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1


> 
> > @@ -463,8 +733,8 @@
> >          :param revision_id: Optional revision id.
> >          """
> >          revision_id = osutils.safe_revision_id(revision_id)
> > -        result = CommitBuilder(self, parents, config, timestamp, timezone,
> > -                              committer, revprops, revision_id)
> > +        result = self.__class__._commit_builder_class(self, parents, config,
> > +            timestamp, timezone, committer, revprops, revision_id)
> 
> I don't see why you're preventing overloading _commit_builder_class on
> particular instances of Repository.  I think self._commit_builder_class
> is more suitable.
> 

Our test suite only understands variation by format at the moment and
every format has a dedicated class, so varying by instance does not
assist us and could encourage the introduction of untested commit
builders; I don't want to encourage that until/unless someone steps up
with a use for it - and the changes (whatever they may be) to get it
tested.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070915/8001c2e2/attachment.pgp