[MERGE] Change CommitBuilder factory delegation to allow simple declaration.

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> This simple patch just moves CommitBuilder above Repository, as part of
> allowing simple declaration of the CommitBuilder class needed for a
> given format (which packs make use of).

Sounds fine.

> @@ -463,8 +733,8 @@
>          :param revision_id: Optional revision id.
>          """
>          revision_id = osutils.safe_revision_id(revision_id)
> -        result = CommitBuilder(self, parents, config, timestamp, timezone,
> -                              committer, revprops, revision_id)
> +        result = self.__class__._commit_builder_class(self, parents, config,
> +            timestamp, timezone, committer, revprops, revision_id)

I don't see why you're preventing overloading _commit_builder_class on
particular instances of Repository.  I think self._commit_builder_class
is more suitable.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG6vMY0F+nu1YWqI0RAp0FAJ9N7YLldhTNlUnvk+CCbmUGaDRU/QCfUPqF
IEzaUAj0v7QL743wXr6pGwo=
=vEW4
-----END PGP SIGNATURE-----