[MERGE][0.91][Bug 133965] PathNotChild, port mismatch with "bzr info" for bzr:// smartserver

Martin Pool mbp at sourcefrog.net
Thu Sep 13 04:41:35 BST 2007


On 9/13/07, Andrew Bennetts <andrew at canonical.com> wrote:

> I wondered about this too.  I decided against it as a YAGNI.  Plus it's not too
> hard to change it later if we ever do think of something more we want to keep —
> unless you think there's an API compatibility issue there?  Although non-bzrlib
> users shouldn't be using transport_list_registry.get_info directly, but instead
> using the register_transport_protocol/get_default_port abstractions, so I think
> we're fine.

If it was public then I'd say to add the space now, but if it's always
reached through accessors then I agree that we can change it if we
need it.  So once you have resolved the questions from Vincent's
review this is ok with me.

-- 
Martin



More information about the bazaar mailing list