[MERGE][0.91][Bug 133965] PathNotChild, port mismatch with "bzr info" for bzr:// smartserver

Andrew Bennetts andrew at canonical.com
Thu Sep 13 03:37:59 BST 2007


Martin Pool wrote:
> Martin Pool has voted tweak.
> Status is now: Conditionally approved
> Comment:
> That looks nice.  However it occurs to me that we might want to keep 
> more than just a default port for a protocol.  Maybe the info should be 
> a dict containing a default_port?

I wondered about this too.  I decided against it as a YAGNI.  Plus it's not too
hard to change it later if we ever do think of something more we want to keep —
unless you think there's an API compatibility issue there?  Although non-bzrlib
users shouldn't be using transport_list_registry.get_info directly, but instead
using the register_transport_protocol/get_default_port abstractions, so I think
we're fine.

-Andrew.




More information about the bazaar mailing list