[MERGE][Bug #52479] Message at the end of commit for bound branches
Robert Collins
robertc at robertcollins.net
Wed Sep 5 00:31:16 BST 2007
On Wed, 2007-09-05 at 00:26 +0100, Daniel Watkins wrote:
> On Tue, 2007-09-04 at 13:18 +1000, Martin Pool wrote:
> > > I wouldn't veto it, but it seems like a half-measure to me. Why show
> > > the location for bound commits, but not regular commits, or commits in
> > > lightweight checkouts?
> > >
> > > And why not show it earlier, so the user can abort the commit if it's
> > > going to the wrong place?
> >
> > That makes sense to me. Daniel, what do you think?
> It makes sense to me.
>
> In the attached I've added a started hook to be called when the initial
> message should be sent. I'm not 100% sure that this is the right way to
> do it but need some input regardless.
bb:approve
this looks reasonable to me.
It might be nice to reduce the duplication in the tests - it seems like
a lot of places were affected by the change, like info used to be.
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070905/4c83e846/attachment.pgp
More information about the bazaar
mailing list