[MERGE][Bug #52479] Message at the end of commit for bound branches
aaron.bentley at utoronto.ca
Wed Sep 5 00:52:08 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Daniel Watkins wrote:
> In the attached I've added a started hook to be called when the initial
> message should be sent. I'm not 100% sure that this is the right way to
> do it but need some input regardless.
This is quite nice. I think the location of the new message is fine--
it should appear before most of the commit activity, giving a nice
chance to see it before the commit is done.
I think the URL should be handled with urlutils.unescape_for_display, so
that local paths aren't unnecessarily ugly. The best place is probably
And Robert makes a good point that we should update the commit tests.
By "reduce the duplication", I take it he means factoring out a helper
method, e.g. assertCommitMessage().
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar