RFC serious defect with changing-kind support

Robert Collins robertc at robertcollins.net
Mon Sep 3 01:14:53 BST 2007


On Mon, 2007-09-03 at 09:29 +1000, Robert Collins wrote:
> in find_previous_heads, I just noticed that there is an if check - if
> the kind has changed we don't record the prior kinds last-changed as a
> parent.
> 
> This will throw 'bzr log FOO' off. 
> 
> I think during the conversion to packs we should look at regenerating
> all this metadata with this bug fixed, as we're going to be recreating
> the inventories anyway to go to split inventories.
> 
> Possibly we should fix this for knits via a check+ reconcile change as
> well.

Further to this it appears that the order of parents for the per-file
graph is undefined due to the use of dictionaries.

I was doing some refactoring for commit, and this is spiraling out of
control, so I'm going to cap it strictly at just doing the rearrangement
I wanted to achieve while we discuss how to tackle this.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070903/90b9d752/attachment.pgp 


More information about the bazaar mailing list