[MERGE] Implement annotation for knits with no annotation cache

Robert Collins robertc at robertcollins.net
Sun Sep 2 23:48:10 BST 2007


On Sun, 2007-09-02 at 18:22 -0400, Aaron Bentley wrote:
> 
> Sure.  I can change it to use the topo_sorted ancestry.

Thanks - that should make your loop simpler :).

> It's mainly historical raisins.  I do think it would be a good idea to
> have cached annotations somewhere, and those could be used to avoid
> building the whole topo-sorted ancestry.

Agreed.

> Also, I think that topological sorting is a bad default behavior,
> because many callers do not need this information to be sorted.  And
> that would reduce the amount of data needed quite a lot.  So I always
> write topo_sorted=False by default. 

Thats fair enough, though a topo sorted index will actually faster
overall if you ask for topo sorted ancestry and use it than asking for
non-topo-sorted and then sort it yourself.

:).

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070903/0c1a82e3/attachment.pgp 


More information about the bazaar mailing list