[MERGE] Implement annotation for knits with no annotation cache

Aaron Bentley aaron.bentley at utoronto.ca
Sun Sep 2 23:22:38 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> bb:tweak
> 
> Seems strange to me to ask for non-topo sorted ancestry then to manually
> topo sort. Could you either note why (e.g. profiling shows our topo sort
> is too slow?) or not do that.

Sure.  I can change it to use the topo_sorted ancestry.

It's mainly historical raisins.  I do think it would be a good idea to
have cached annotations somewhere, and those could be used to avoid
building the whole topo-sorted ancestry.

Also, I think that topological sorting is a bad default behavior,
because many callers do not need this information to be sorted.  And
that would reduce the amount of data needed quite a lot.  So I always
write topo_sorted=False by default.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG2zeu0F+nu1YWqI0RAtkzAJ4v+xOUzW9Eh++aGrpoMO3E/uUA0gCfVssK
QCslUjW1e6ExK9IXdQRtx84=
=OH4/
-----END PGP SIGNATURE-----



More information about the bazaar mailing list