[MERGE #102747] pre_commit hook

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:
> Ian Clatworthy wrote:
>> Ian Clatworthy has voted resubmit.
>> Status is now: Resubmit
>> Comment:
>> Everything looks fine to me here *except* the location in the code
>> whether you're calling the pre-commit hooks. It looks like that's being
>> done after the commit to the local branch which isn't what I (at least)
>> expect of a pre-commit hook. Perhaps we should discuss the best location
>> on #IRC?
> 
>> Could you also update the very recently added hook documentation that
>> Aaron has added?
> 
> I think you are misunderstanding this.

I agree.  The commit doesn't take effect until the branch has been updated.

But I think it's easy to misunderstand.  Perhaps CommitBuilder's commit
method could be renamed to something like "finish_revision"?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG2CNA0F+nu1YWqI0RAmcgAJ9PFqyRU8iGgN/c69eWwZC6HK7GaQCghIA/
nfFzZq2In5MQn125l38JG3U=
=7IjO
-----END PGP SIGNATURE-----