[MERGE #102747] pre_commit hook

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> Ian Clatworthy has voted resubmit.
> Status is now: Resubmit
> Comment:
> Everything looks fine to me here *except* the location in the code
> whether you're calling the pre-commit hooks. It looks like that's being
> done after the commit to the local branch which isn't what I (at least)
> expect of a pre-commit hook. Perhaps we should discuss the best location
> on #IRC?
> 
> Could you also update the very recently added hook documentation that
> Aaron has added?

I think you are misunderstanding this.

It is explicitly done after the commit has been put together, but before the
last_revision is updated.

That way you are sure of exactly how the commit will be. (No ability to change
the files, etc).

The local branch's last revision is set *after* the master branch's.

We can certainly discuss this more, but I'm pretty sure he did it in the right
location.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG2BhuJdeBCYSNAAMRAjlQAKCeY0j1UAXLp4o8lvgKJPXZ9AzhaQCgyuDF
pekaFvTmCWzjrhaWWmmkH4I=
=jnKb
-----END PGP SIGNATURE-----