[MERGE][0.90][Bug 133965] PathNotChild, port mismatch with "bzr info" for bzr:// smartserver

[Andrew Bennetts]

John Arbash Meinel wrote:
[...]
> > 
> > Because that's where _split_url and _unsplit_url live at the moment.  Probably
> > that should be changed.  I wanted to keep the patch fairly minimal so that it
> > could be considered for 0.90 (although perhaps John's fix is more appropriate
> > for 0.90, because it's truly minimal).
> > 
> > -Andrew.
> 
> UDP would also probably maintain a Connection type object. It may not maintain
> an active socket, but it would probably keep track of who it was talking to,
> and what password to use.
> 
> AFAIK, the only transport that *isn't* a ConnectedTransport is the Local transport.
> 
> Arguably the _split_url and _unsplit_url could be moved onto the base Transport
> class rather than the derived ConnectedTransport. I don't remember exactly why
> Vincent wanted the split, but I think there was a reason.

I agree.  Splitting and unsplitting of URLs really shouldn't depend on the
Transport at all.  Ideally those functions would live in urlutils.

On the other hand, this is already an uncomfortably large patch for 0.90.  I
really don't want to make any deeper changes for 0.90, James has enough to worry
about as it is :)

-Andrew.