[MERGE][0.90][Bug 133965] PathNotChild, port mismatch with "bzr info" for bzr:// smartserver

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> Robert Collins wrote:
>> Why does only ConnectedTransport get this? udp style protocols have
>> url's too...
>>
>> -Rob
> 
> Because that's where _split_url and _unsplit_url live at the moment.  Probably
> that should be changed.  I wanted to keep the patch fairly minimal so that it
> could be considered for 0.90 (although perhaps John's fix is more appropriate
> for 0.90, because it's truly minimal).
> 
> -Andrew.

UDP would also probably maintain a Connection type object. It may not maintain
an active socket, but it would probably keep track of who it was talking to,
and what password to use.

AFAIK, the only transport that *isn't* a ConnectedTransport is the Local transport.

Arguably the _split_url and _unsplit_url could be moved onto the base Transport
class rather than the derived ConnectedTransport. I don't remember exactly why
Vincent wanted the split, but I think there was a reason.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG0cwnJdeBCYSNAAMRAnhwAJ9YM8qzJ0M84ukBSC44kvg4is8j7ACggXTI
92ME3u2URKiUpN0G6cWU+Ac=
=JxHK
-----END PGP SIGNATURE-----