[MERGE] remove spurious call in revision store add_revision.

Robert Collins robertc at robertcollins.net
Wed Aug 22 23:10:05 BST 2007


On Wed, 2007-08-22 at 13:29 -0400, John Arbash Meinel wrote:
> John Arbash Meinel has voted tweak.

> ... but we should also avoid calling 
> methods on the return value of functions rather than using a variable)

Why? This is the first I've heard of this, and I think its a pretty
nasty smell to use a temporary variable where none is needed.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070823/8dc54895/attachment.pgp 


More information about the bazaar mailing list