[MERGE] remove spurious call in revision store add_revision.

[John Arbash Meinel]

John Arbash Meinel has voted tweak.
Status is now: Conditionally approved
Comment:
I think this is better expressed as:
--- bzrlib/store/revision/knit.py       2007-07-10 21:18:54 +0000
+++ bzrlib/store/revision/knit.py       2007-08-22 17:29:04 +0000
@@ -66,7 +66,7 @@
          """Template method helper to store revision in this store."""
          # FIXME: make this ghost aware at the knit level
          rf = self.get_revision_file(transaction)
-        self.get_revision_file(transaction).add_lines_with_ghosts(
+        rf.add_lines_with_ghosts(
              revision.revision_id,
              revision.parent_ids,
              osutils.split_lines(revision_as_file.read()))

(yes we don't want to grab it 2 times, but we should also avoid calling 
methods on the return value of functions rather than using a variable)


For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C1187769900.17572.106.camel%40localhost.localdomain%3E