[MERGE] Transport support for pack repositories

[Robert Collins]

On Thu, 2007-08-09 at 00:22 -0400, Martin Pool wrote:
> Martin Pool has voted tweak.
> Status is now: Conditionally approved
> Comment:
> Please rename open_file_stream to open_write_stream or open_write or 
> open_file_write_stream: something that makes it clear it's for writing.

Done.
..
> The return value clause comments about close() seem contradictory
> with the promise above that readv and get will be synchronized.
> 
> Aside from that it's ok.

Uh, they aren't. If you do a get, you may get data from a buffer, or it
may sync to disk, the interface doesn't specify. If you don't close,
your data may not hit disk. Better wording solicited.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: transport-pack.patch
Type: text/x-patch
Size: 34065 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070815/4b7fbd51/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070815/4b7fbd51/attachment-0001.pgp