[MERGE] New option --author for commit

[Lukáš Lalinský]

On Ut, 2007-08-14 at 12:36 -0400, John Arbash Meinel wrote:
> John Arbash Meinel has voted tweak.
> Status is now: Conditionally approved
> Comment:
> I'm not sure you should remove the test entirely.Instead "assert author 
> not in revprops" you could:
> 
> if author in revprops:
>    raise AssertionError()
> 
> which will always be raised.

Hm, I actually quite like that it is a regular assert, that is removed
in the optimized mode. If you think I should re-add the test then I'd
probably rather do something like:

try:
    assert False
except AssertionError:
    self.assertRaises(AssertionError, tree.commit, 'commit 1',
                      author='John Doe <jdoe at example.com>',
                      revprops={'author': ''})

> The only other question is whether the Author should be displayed in 
> short logs, rather than the committer.

I'll submit another patch that displays the author in annotate and all
log formats by default. But I didn't want to combine these patches,
because this second one is quite radical change and might be
questionable if it's a good idea.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Toto je =?ISO-8859-1?Q?digit=E1lne?=
	=?ISO-8859-1?Q?_podp=EDsan=E1?= =?UTF-8?Q?_=C4=8Das=C5=A5?=
	=?ISO-8859-1?Q?_spr=E1vy?=
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070815/303e6b55/attachment.pgp