[MERGE] New option --author for commit

John Arbash Meinel john at arbash-meinel.com
Tue Aug 14 17:36:43 BST 2007


John Arbash Meinel has voted tweak.
Status is now: Conditionally approved
Comment:
I'm not sure you should remove the test entirely.Instead "assert author 
not in revprops" you could:

if author in revprops:
   raise AssertionError()

which will always be raised.

Author is the type of value that I would like to see end up as a 
first-class value, rather than just in the revision properties 
dictionary. But for now, this is a safe enough way to do it.

The only other question is whether the Author should be displayed in 
short logs, rather than the committer. If we change the pqm to use 
--author as the person requesting the submission (since they, in effect, 
authored the merge commit), it would make 'bzr log --short bzr.dev' a 
bit more interesting. Though really the primary author should be the 
person who does the patch, and then we would have submitter. (Either way 
makes bzr log --short more interesting for bzr.dev.)

So, if we decide we don't need to test the assert, this is ready.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C1186552601.6203.9.camel%40nemo%3E



More information about the bazaar mailing list