[Merge][#111665] bzr rm should remove clean subtrees

Alexander Belchenko bialix at ukr.net
Tue Aug 14 14:51:21 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marius, I apologize if my previous review seemed too pedantic.

>>>          files = [f for f in new_files]
>> ^-- does list comprehension is faster than slicing operation?
> my problem was that new_files is a set,
> I implemented Andrew's suggestion:
>   files = list(new_files)

Oh, sorry. I missed the fact that new_files is a set, not a list.
Surely, in this case Andrew's suggestion is most accurate.

bb:approve

[µ]

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGwbNZzYr338mxwCURAlF6AJ4ijs/ZI8+AnO29lofqgIYSpysrCwCgjcK+
ScBjb3XRc73co0+lGNCVY/0=
=qivW
-----END PGP SIGNATURE-----



More information about the bazaar mailing list